On Sun, May 17, 2009 at 10:06, Krzysztof Helt [off-list ref] wrot=
e:

On Fri, 15 May 2009 12:19:17 -0600 Grant Likely <grant.likely@secretlab.c=

a> wrote:

quoted

diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
index 40a3a2a..7a868bd 100644
--- a/drivers/video/xilinxfb.c
+++ b/drivers/video/xilinxfb.c

@@ -107,17 +111,28 @@ static struct fb_var_screeninfo xilinx_fb_var =3D =

{

quoted

=C2=A0 =C2=A0 =C2=A0 .activate =3D =C2=A0 =C2=A0 FB_ACTIVATE_NOW
=C2=A0};

+
+#define PLB_ACCESS_FLAG =C2=A0 =C2=A0 =C2=A00x1 =C2=A0 =C2=A0 =C2=A0 =

=C2=A0 =C2=A0 =C2=A0 /* 1 =3D PLB, 0 =3D DCR */

quoted

+
=C2=A0struct xilinxfb_drvdata {

=C2=A0 =C2=A0 =C2=A0 struct fb_info =C2=A0info; =C2=A0 =C2=A0 =C2=A0 =C2=

=A0 =C2=A0 /* FB driver info record */

quoted

- =C2=A0 =C2=A0 u32 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 regs_phys;=

 =C2=A0 =C2=A0 =C2=A0/* phys. address of the control registers */

quoted

- =C2=A0 =C2=A0 u32 __iomem =C2=A0 =C2=A0 *regs; =C2=A0 =C2=A0 =C2=A0 =

=C2=A0 =C2=A0/* virt. address of the control registers */

quoted

+ =C2=A0 =C2=A0 phys_addr_t =C2=A0 =C2=A0 regs_phys; =C2=A0 =C2=A0 =C2=

=A0/* phys. address of the control

quoted

+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 registers */

There are fields fb_info.fix.mmio_start and fb_info.fix.mmio_len for
physical IO range used by framebuffer. There is no field for
virtual IO address so the "regs" below must stay.

If I'm not mistaken, this driver is used on ppc44x, where phys_addr_t is 64=
-bit,
so the 32-bit unsigned long fb_info.fix.mmio_start is not large enough
to hold the
physical address.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
							    -- Linus Torvalds