Thread (13 messages) flat view 13 messages, 4 authors, 2009-01-13

Re: [PATCH 3/5] powerpc: booke: Remove code duplication in lowmem mapping

From: Kumar Gala <hidden>
Date: 2009-01-13 15:45:11

On Dec 8, 2008, at 9:34 PM, Trent Piepho wrote:
The code to map lowmem uses three CAM aka TLB[1] entries to cover  
it.  The
size of each is stored in three globals named __cam0, __cam1, and  
__cam2.
All the code that uses them is duplicated three times for each of  
the three
variables.

We have these things called arrays and loops....

Once converted to use an array, it will be easier to make the number  
of
CAMs configurable.

Signed-off-by: Trent Piepho <redacted>
---
arch/powerpc/mm/fsl_booke_mmu.c |   79 ++++++++++++++ 
+-----------------------
1 files changed, 31 insertions(+), 48 deletions(-)
applied.  Still not happy about the buf[] for output, but its minor.

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help