Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code

On Mon, 13 Oct 2008 20:52:25 -0500
Kumar Gala [off-list ref] wrote:

On Oct 13, 2008, at 6:30 PM, Benjamin Herrenschmidt wrote:

quoted

On Mon, 2008-10-13 at 13:22 -0500, Kumar Gala wrote:

quoted

quoted

I don't think it matters much when it gets fixed, pre or post -rc1.
But
it should probably get fixed.  My hack was to pull isa_bridge_pcidev
into pci-common.c and export it from there.  The 64-bit PCI code can
initialized it, and the 32-bit can leave it NULL.  But I have no  
idea
if that is sane.  If so, I can probably submit a patch for it.

I was just joking around about our "new" regression policy..  
anyways I
hope ben or maybe anton can comment about the ISA code.

My policy for that sort of bug is fix ASAP. I'll give it a go when I  
do
my test builds. Funny I didn't catch it, I might be lacking a chrp32
defconfig in my build tests :-)

I pointed out to Stephen that kisskb.ellerman.id.au hasn't been  
updating.. there is a chrp32 defconfig in there that would normally  
catch something like this.

Except if kissb catches it, it's already committed in tree.  Better
than nothing, but it would be nice if people did a buildall before they
commit.

josh