Thread (33 messages) flat view 33 messages, 8 authors, 2016-06-15

Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-10-13 23:30:11

On Mon, 2008-10-13 at 14:21 -0400, Josh Boyer wrote:
I don't think it matters much when it gets fixed, pre or post -rc1.  But
it should probably get fixed.  My hack was to pull isa_bridge_pcidev
into pci-common.c and export it from there.  The 64-bit PCI code can
initialized it, and the 32-bit can leave it NULL.  But I have no idea
if that is sane.  If so, I can probably submit a patch for it.
I think the proper fix in the long run is to make the isa bridge
handling code in pci-64 common, but that's going to be after I rework
the IO space allocation/mapping mechanisms for pci-32 to also look like
pci-64 so it will take a little while.

In the meantime, I agree, just leave it to NULL, we can do a better
fixup on top of that. As it is, it's going to hurt Pegasos too (the
other 5 users :-)

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help