Re: [PATCH 2/6] kvmppc: add hypercall infrastructure - host part
From: Geert Uytterhoeven <hidden>
Date: 2008-07-30 13:41:11
On Thu, 24 Jul 2008, Tony Breeds wrote:
On Wed, Jul 23, 2008 at 10:36:43AM +0200, ehrhardt@linux.vnet.ibm.com wrote:quoted
From: Christian Ehrhardt <redacted>diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c --- a/arch/powerpc/kvm/emulate.c +++ b/arch/powerpc/kvm/emulate.c@@ -203,6 +203,24 @@ kvmppc_set_msr(vcpu, vcpu->arch.srr1); } +static int kvmppc_do_hypercall(struct kvm_vcpu *vcpu) +{ + int ret = 0; + + switch (vcpu->arch.gpr[0]) { + default: + printk(KERN_ERR"unknown hypercall %d\n", vcpu->arch.gpr[0]);I think the preffered style is printk(KERN_ERR "...) You've made the same style mistake in most of you printk()'s in your other patches aswell.
Note that these days people use pr_err() instead. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@eu.sony.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis 293-0376800-10 GEBA-BE-BB