Thread (13 messages) flat view 13 messages, 5 authors, 2008-07-15

Re: [RFC] [PATCH] task_pt_regs for powerpc systems

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-07-14 10:05:47

On Mon, 2008-07-14 at 14:01 +0530, Srinivasa D S wrote:
On Monday 14 July 2008 04:02:41 am Paul Mackerras wrote:
quoted
quoted
 Below attached patch  defines this macro for powerpc arch. Please let
me know your comments on this.

+#define task_pt_regs(tsk)	((struct pt_regs *)(tsk)->thread.regs)
The cast is unnecessary since tsk->thread.regs is already a struct
pt_regs *. 
True.
quoted
Also note that tsk->thread.regs will be NULL for a kernel 
thread.
Yes, users of task_pt_regs will verify for NULL.  Updated patch attached 
below.

Signed-off-by: Srinivasa DS <redacted>
Can you send a cleanup patch against powerpc.git instead ?

Thanks !

Ben
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help