Thread (59 messages) flat view 59 messages, 9 authors, 2008-08-29

Re: [PATCH v2] leds: implement OpenFirmare GPIO LED driver

From: Richard Purdie <hidden>
Date: 2008-07-15 14:44:32
Also in: lkml

On Tue, 2008-07-15 at 18:23 +0400, Anton Vorontsov wrote:
quoted
Spell out openfirmware :). I initially had no idea "of == openfirmware"
and I suspect others won't either...
This would be unusually long name, that is

$ find . -iname '*openfirmware*' | wc -l
0

And in contrast:

drivers/video/offb.c
drivers/video/nvidia/nv_of.c
drivers/usb/host/ohci-ppc-of.c
drivers/usb/host/ehci-ppc-of.c
drivers/serial/of_serial.c
drivers/mtd/maps/physmap_of.c
...

So, I think we should stick with the "of" for consistency, while
confused users may consult with Kconfig for disambiguation.
The other cases don't have a gpio driver to confuse this new driver
with. Lets spell it out please, the filesystems can handle the extra
letters :).

Cheers,

Richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help