Re: [PATCH 48/60] microblaze_v4: headers simple files - empty or redirect to asm-generic
From: Adrian Bunk <bunk@kernel.org>
Date: 2008-06-26 16:23:38
Also in:
linux-arch, lkml
From: Adrian Bunk <bunk@kernel.org>
Date: 2008-06-26 16:23:38
Also in:
linux-arch, lkml
On Thu, Jun 26, 2008 at 05:35:11PM +0200, Arnd Bergmann wrote:
On Thursday 26 June 2008, monstr@seznam.cz wrote:quoted
+ +#ifndef _ASM_MICROBLAZE_NAMEI_H +#define _ASM_MICROBLAZE_NAMEI_H + +#ifdef __KERNEL__ + +/* This dummy routine maybe changed to something useful + * for /usr/gnemul/ emulation stuff. + * Look at asm-sparc/namei.h for details. + */ +#define __emul_prefix() NULL + +#endif /* __KERNEL__ */ + +#endif /* _ASM_MICROBLAZE_NAMEI_H */Could you move this to asm-generic? Note that the comment is wrong, asm-sparc doesn't actually implement it any more, only ia64, mips and arm have an implementation that actually does something interesting here.
The comment could be nuked (as well as the #ifdef __KERNEL__), but for the one #define an asm-generic header would IMHO be overkill.
Arnd <><
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed