Re: [PATCH 33/60] microblaze_v4: includes SHM*, msgbuf
From: Arnd Bergmann <arnd@arndb.de>
Date: 2008-06-26 15:18:33
Also in:
linux-arch, lkml
From: Arnd Bergmann <arnd@arndb.de>
Date: 2008-06-26 15:18:33
Also in:
linux-arch, lkml
On Thursday 26 June 2008, monstr@seznam.cz wrote:
=A0include/asm-microblaze/msgbuf.h =A0 | =A0 39 +++++++++++++++++++++++++=
+++
=A0include/asm-microblaze/shmbuf.h =A0 | =A0 50 +++++++++++++++++++++++++=
++++++++++++
=A0include/asm-microblaze/shmparam.h | =A0 14 ++++++++++ =A03 files changed, 103 insertions(+), 0 deletions(-) =A0create mode 100644 include/asm-microblaze/msgbuf.h =A0create mode 100644 include/asm-microblaze/shmbuf.h =A0create mode 100644 include/asm-microblaze/shmparam.h =20
These files are ok, but IMHO they should be in asm-generic, since there are already many identical copies. While the implementation of these three, as well as ipcbuf.h and sembuf.h could be better optimized for endianess and word size differences, I have come to the conclusion that there is no point for them to really be different, and uClibc expects this exact layout by default anyway. Arnd <><