RE: [PATCH] [RFC] Xilinx: Add generic configuration option to enable all xilinx drivers.

My feeling is if the drivers should be consistently enabled or not, then
we should enforce that consistency by the structure of the code.

Steve

-----Original Message-----
From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of

Grant Likely

Sent: Tuesday, March 18, 2008 10:06 PM
To: Stephen Neuendorffer
Cc: linuxppc-dev@ozlabs.org; jacmet@sunsite.dk
Subject: Re: [PATCH] [RFC] Xilinx: Add generic configuration option to

enable all xilinx drivers.

=20
On Tue, Mar 18, 2008 at 10:32 PM, Stephen Neuendorffer
[off-list ref] wrote:

quoted

Hmm... interesting points.  I guess my feeling was that

XILINX_DRIVERS could

quoted

be a more broadly configurable option, with some of these ideas in

mind.

quoted

Currently, it's hidden by default, but we could easily change this

to be

quoted

visible by default, or selected by a broader number of

architectures.  I

quoted

tend to think about them as a group: What if x86 *did* support the
primitives needed by these drivers, then if the individual drivers

depend on

quoted

XILINX_DRIVERS, then the modification could be made in one spot.  By

your

quoted

suggestion, we would have to modify each one independantly.

=20
Heh; it's not *that* many drivers and it's just Kconfig stuff which is
real easy to change.  My preference would be to eliminate
XILINX_DRIVERS entirely, but I'm not going to fight about it.  :-)
=20
Cheers,
g.
=20
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.