Re: [PATCH 2/2] [POWERPC] Add L2 cache node to AMCC Taishan dts file

On Wednesday 19 March 2008, David Gibson wrote:

On Tue, Mar 18, 2008 at 02:37:46PM +0100, Stefan Roese wrote:

quoted

This patch adds the L2 cache node to the Taishan 440GX dts file.

Signed-off-by: Stefan Roese <sr@denx.de>
---
 arch/powerpc/boot/dts/taishan.dts     |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/taishan.dts

b/arch/powerpc/boot/dts/taishan.dts index 8278068..d0bff33 100644

--- a/arch/powerpc/boot/dts/taishan.dts
+++ b/arch/powerpc/boot/dts/taishan.dts

@@ -104,6 +104,16 @@
 		// FIXME: anything else?
 	};

+	L2C0: l2c@30 {

A node with no reg property shouldn't have a unit address.

OK, I'll remove the unit address.

quoted

+		compatible = "ibm,l2-cache-440gx", "ibm,l2-cache";
+		dcr-reg = <20 8			/* Internal SRAM DCR's */
+			   30 8>;		/* L2 cache DCR's */
+		cache-line-size = <20>;		/* 32 bytes */
+		cache-size = <40000>;		/* L2, 256K */
+		interrupt-parent = <&UIC2>;
+		interrupts = <17 1>;
+	};

Now.. usually cache nodes are given as descendents of the CPU node.
In this case you have the DCR control registers though, so I guess
this is representing a control interface rather than the cache
itself.  Hrm.. not really sure how to do this.

So should I change the location then?

Best regards,
Stefan