Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

On Tue, 2008-03-11 at 17:12 +1100, Paul Mackerras wrote:

Manish Ahuja writes:

quoted

+#else /* CONFIG_PHYP_DUMP */
+int early_init_dt_scan_phyp_dump(unsigned long node,
+		const char *uname, int depth, void *data) { return 0; }

This shouldn't be in the header file.  Either put it in prom.c (and
make it return 1 so the of_scan_flat_dt call doesn't have to go
through the entire device tree), or put #ifdef CONFIG_PHYP_DUMP around
the of_scan_flat_dt call itself.

It should be in the header file, otherwise we need an #ifdef around the
call site - which is uglier.

It should definitely return 1 though.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person