Re: [PATCH 4/8] pseries: phyp dump: register dump area.
From: Paul Mackerras <hidden>
Date: 2008-03-11 06:17:50
From: Paul Mackerras <hidden>
Date: 2008-03-11 06:17:50
Manish Ahuja writes:
+#define NUM_DUMP_SECTIONS 3 +#define DUMP_HEADER_VERSION 0x1 +#define DUMP_REQUEST_FLAG 0x1 +#define DUMP_SOURCE_CPU 0x0001 +#define DUMP_SOURCE_HPTE 0x0002 +#define DUMP_SOURCE_RMO 0x0011
I think it would be clearer if you use a tab to line up the values, like this: #define NUM_DUMP_SECTIONS 3 #define DUMP_HEADER_VERSION 0x1 #define DUMP_REQUEST_FLAG 0x1 #define DUMP_SOURCE_CPU 0x0001 #define DUMP_SOURCE_HPTE 0x0002 #define DUMP_SOURCE_RMO 0x0011 Paul.