Re: [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations
From: Jesse Barnes <hidden>
Date: 2008-03-03 18:52:31
Also in:
linux-arch
From: Jesse Barnes <hidden>
Date: 2008-03-03 18:52:31
Also in:
linux-arch
On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote:
There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch consolidates most of them to use the version annotated below. This is the original x86 version, except that it uses the resource collision check from powerpc at (5):
Looks really good to me, definitely a step in the right direction.
The mips/pmc-sierra implementation of pcibios_enable_resources() is cluttered with a bunch of titan stuff, so I can't immediately consolidate it with the others. So I made the generic version "weak" so pmc-sierra can override it. Not-Yet-Signed-off-by: Bjorn Helgaas [off-list ref]
So you'd like to see the MIPS stuff cleaned up a bit more first before actual sign-off? Or just more testing?
18 files changed, 43 insertions(+), 507 deletions(-)
Nice diffstat. :) Jesse