Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources()
From: Jesse Barnes <hidden>
Date: 2008-03-03 18:00:44
Also in:
linux-arch
On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote:
Move bridge enable from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared.
I really like the direction of these patches. Getting PCI resources assigned & devices setup correctly for new arches has always been a bit more trouble than it should be...
quoted hunk ↗ jump to hunk
Signed-off-by: Bjorn Helgaas <redacted> Index: work6/arch/arm/kernel/bios32.c ===================================================================--- work6.orig/arch/arm/kernel/bios32.c 2008-02-27 11:25:29.000000000 -0700 +++ work6/arch/arm/kernel/bios32.c 2008-02-27 11:55:59.000000000 -0700@@ -683,15 +683,32 @@ cmd |= PCI_COMMAND_MEMORY; } + if (cmd != old_cmd) { + printk("PCI: enabling device %s (%04x -> %04x)\n", + pci_name(dev), old_cmd, cmd);
Probably worth giving this printk a prefix at some point (doesn't matter for this patchset though since you're just moving it around). Rest of it looks good. Jesse