Re: [PATCH 2/2 v2] [POWERPC] Ignore disabled serial ports
flat view
From: Arnd Bergmann <arnd@arndb.de>
Date: 2008-03-03 03:43:59
On Saturday 01 March 2008, Josh Boyer wrote:
quoted hunk ↗ jump to hunk
--- linux-2.6.orig/drivers/serial/of_serial.c +++ linux-2.6/drivers/serial/of_serial.c@@ -72,6 +72,11 @@ static int __devinit of_platform_serial_=A0=A0=A0=A0=A0=A0=A0=A0int port_type; =A0=A0=A0=A0=A0=A0=A0=A0int ret; =A0 +=A0=A0=A0=A0=A0=A0=A0if (!of_device_is_available(ofdev->node)) { +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0dev_info(&ofdev->dev, "Disa=
bled serial port. =A0Ignored\n");
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return -ENODEV; +=A0=A0=A0=A0=A0=A0=A0} + =A0=A0=A0=A0=A0=A0=A0=A0if (of_find_property(ofdev->node, "used-by-rtas",=
NULL))
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return -EBUSY;
I wonder whether we should move the check for "used-by-rtas" into the of_device_is_available function. I understand that used-by-rtas is another way of expressing the idea that the kernel is not supposed to access the specific device. In this case, the device is physically present, but is not available to the OS. Arnd <><