Thread (21 messages) 21 messages, 10 authors, 2008-03-26

Re: [PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs

flat view

From: Josh Boyer <hidden>
Date: 2008-03-02 22:25:56

On Sun, 02 Mar 2008 14:43:31 -0500
Sean MacLennan [off-list ref] wrote:
Josh Boyer wrote:
quoted
Convert ibm_newemac to use the of_device_is_available function when checking
for unused/unwired EMACs.  We leave the current check for an "unused" property
to maintain backwards compatibility for older device trees.  Newer device
trees should simply use the standard "status" property in the EMAC node.

The taishan DTS file is updated to reflect this.
  
What is the advantage of documenting unwired devices? I ask because the 
taco does not have emac1 connected. I handle it by not defining emac1 in 
the dts file.
If it never has the possibility of becoming usable without some kind
of hardware rework, then that's probably best.
Is it better to document it and disable it? Or is this mainly for 
reference boards to show that while the PPC supports to emacs, only one 
is enabled on the reference board?

i.e. We want reference design boards to show what *could* be done, but 
production boards to show what *is* done?
Sort of.  A lot of these eval boards have DIP switches that change pins
to various devices.  So for those, we enumerate most things and we can
adjust the status property based on those settings in the
firmware/wrapper.

josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help