Re: Could the DTS experts look at this?

On Tue, Feb 12, 2008 at 09:44:39AM -0600, Timur Tabi wrote:

Arnd Bergmann wrote:

quoted

On Tuesday 12 February 2008, David Gibson wrote:

quoted

Or to expand.  It's relatively easy now to just include multiple nodes
in the tree and either delete or nop some of them out conditionally
using libfdt.  

Yes, but what better place to store the conditions than in the
device tree itself?  How would libfdt know where the conditions are?
Do you want to have two binary blobs?

libfdt wouldn't.  The conditional logic must be in the agent using
libfdt.

quoted

quoted

But the conditional logic should be in the manipulating
agent (u-boot or bootwrapper or whatever), there's no way we're going
to require a conditional expression parser to interpret the device
tree blob itself.

I think it's a great feature that solves a lot of problems, and it
does so in an elegant and efficient manner.  I look forward to
trying to change your mind when I get around to implementing it.

quoted

How about making the logic to nop out nodes a little more generic
without changes to the binary format?
E.g. you could have a "linux,conditional-node" property in the device
tree whose value is compared to a HW configuration specific string.

The problem with this is that if you use a version of libfdt that
does not understand "linux,conditional-node", then your device tree
will be wrong, because it could contain nodes that don't belong.  We
would need a new, incompatible version number for the device tree to
make sure that this doesn't happen, even though nothing has changed
in the binary layout of the tree.

Passing an incomplete device tree to an agent that doesn't expect it
is always going to cause trouble.  This is nothing new.  And as you've
said the interpretation of these variables in the conditionals is
already agent specific, so you'd still have to pass these
conditionalised trees to the correct agent in order for them to be
correctly interpreted.

No, this has to be agent-local logic.  If you want to annotate your
agent's input device trees with information that will help it do this,
go for it, but don't expect it to be in any way a standardized aspect
of the device tree format.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson