Re: Could the DTS experts look at this?

On Feb 12, 2008 8:44 AM, Timur Tabi [off-list ref] wrote:

Arnd Bergmann wrote:

quoted

On Tuesday 12 February 2008, David Gibson wrote:

quoted

Or to expand.  It's relatively easy now to just include multiple nodes
in the tree and either delete or nop some of them out conditionally
using libfdt.

Yes, but what better place to store the conditions than in the device tree
itself?  How would libfdt know where the conditions are?  Do you want to have
two binary blobs?

The transient state of the dts before it is handed to the kernel
proper is almost irrelevant.  It is totally reasonable to add in
whatever properties/nodes that are needed to *eventually* describe the
hardware correctly.  Heck, we already do this will all dts files that
go through u-boot is a simple sense.  We put placeholder properties
for mac addresses and bus frequencies, but u-boot fills them in.

However, if a designer does write a device tree containing more nodes
than is needed, then it is also the responsibility of that designer to
make sure the boot loader can use that tree to generate a real
description of hardware.  This requires coordination and
documentation, but id does not requires special formatting or
versioning of the device tree blob.

The dtb is a data structure, not a programming language.  I think it
is a slippery slope to try and encode conditionals into the structure;
but it is entirely reasonable to encode *data* into the dt that helps
make those conditional decisions.

quoted

quoted

But the conditional logic should be in the manipulating
agent (u-boot or bootwrapper or whatever), there's no way we're going
to require a conditional expression parser to interpret the device
tree blob itself.

I think it's a great feature that solves a lot of problems, and it does so in an
elegant and efficient manner.  I look forward to trying to change your mind when
I get around to implementing it.

I agree with David here; logic belongs in the agent code, not the data
structure.

quoted

How about making the logic to nop out nodes a little more generic
without changes to the binary format?
E.g. you could have a "linux,conditional-node" property in the device
tree whose value is compared to a HW configuration specific string.

The problem with this is that if you use a version of libfdt that does not
understand "linux,conditional-node", then your device tree will be wrong,
because it could contain nodes that don't belong.  We would need a new,
incompatible version number for the device tree to make sure that this doesn't
happen, even though nothing has changed in the binary layout of the tree.

We've already got that issue.  If you pass the device tree for the
wrong board it will still validate correctly, but the board is not
going to boot.  The device tree must match what the bootloader
expects.  Changing the version number will do nothing to help this.
The version number ensures that the tree is parsable.  It does not
ensure that it is correct.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.