Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

On Wed, 9 Jan 2008 18:36:34 -0600 Olof Johansson [off-list ref] wrote:

On Thu, Jan 10, 2008 at 10:40:48AM +1100, Stephen Rothwell wrote:

quoted

Hi Anton,

Juts one small trivial comment (could be fixed later).

On Wed, 9 Jan 2008 22:10:41 +0300 Anton Vorontsov [off-list ref] wrote:

quoted

+static struct of_device_id pata_of_platform_match[] = {

This could be declared const.

Good point, but let's not hold up merge based on this. Need something
for janitors to do too, and it's good enough to merge as-is. :)

Absolutely. To me that is what "(could be fixed later)" means.  :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/