Re: [PATCH 4/5] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

On 1/2/08, Jochen Friedrich [off-list ref] wrote:

Should this go into some central file? Else we would have to copy it in any i2c bus driver that supports powerpc.
This would at least be i2c-cpm and i2c-gpio.

I can change that in the next rev. I'm waiting to see if there are any
more changes.

IMHO, there should be a node attribute to override i2c_adapter.class. Legacy i2c drivers (in particular v4l and dvb drivers) use this class to decide which adapter to bind to. dbox2 needs I2C_CLASS_TV_DIGITAL (4).

I hadn't paid any attention to i2c_adapter.class. Now that you mention
it I wonder why i2c has it.  It appears to be a holdover from the
older mechanism of searching for devices and it is used as a filter to
reduce the number of device being searched. I would think a new style
driver could just ignore it.

It is probably best to fix it in a successive patch.


-- 
Jon Smirl
jonsmirl@gmail.com