=20

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]=20
=20
On Jan 31, 2008, at 12:15 AM, Kumar Gala wrote:
=20

quoted

On Jan 30, 2008, at 11:57 PM, Zhang Wei wrote:

quoted

quoted

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]

On Jan 30, 2008, at 4:30 AM, Zhang Wei wrote:

quoted

Change lots of static variable to mport private. And add

mport to some

quoted

function declaration.

Can you explain this patch further.  Its not clear=20

exactly from this

quoted

quoted

quoted

commit message why we are doing this.

- k

Sorry about I have a little hurry about it.

The original RapidIO driver suppose there is only one mpc85xx RIO
controller
in system. So, some data structures are defined as mpc85xx_rio =20
global,
such as 'regs_win', 'dbell_ring', 'msg_tx_ring'. Now, I=20

changed them

quoted

quoted

to
mport's private members. And you can define multi RIO=20

OF-nodes in dts

quoted

quoted

file
for multi RapidIO controller in one processor, such as PCI/PCI-Ex =20
host
controllers
in Freescale's silicon. And the mport operation function=20

declaration

quoted

quoted

should be changed
to know which RapidIO controller is target.

thanks, this makes a lot of sense and now reviewing the patch will
make some sense to me :)

=20
when we have multiple ports are the device IDs on the ports intended =20
to be unique only to a port or unique across all ports?
=20

I consider each RIO controller will has its own network, the device IDs
should be
unique only in its port network.

Cheers!
Wei