On Jan 30, 2008, at 11:57 PM, Zhang Wei wrote:

quoted

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]

On Jan 30, 2008, at 4:30 AM, Zhang Wei wrote:

quoted

Change lots of static variable to mport private. And add

mport to some

quoted

function declaration.

Can you explain this patch further.  Its not clear exactly from this
commit message why we are doing this.

- k

Sorry about I have a little hurry about it.

The original RapidIO driver suppose there is only one mpc85xx RIO
controller
in system. So, some data structures are defined as mpc85xx_rio global,
such as 'regs_win', 'dbell_ring', 'msg_tx_ring'. Now, I changed them  
to
mport's private members. And you can define multi RIO OF-nodes in dts
file
for multi RapidIO controller in one processor, such as PCI/PCI-Ex host
controllers
in Freescale's silicon. And the mport operation function declaration
should be changed
to know which RapidIO controller is target.

thanks, this makes a lot of sense and now reviewing the patch will  
make some sense to me :)

- k