Thread (34 messages) 34 messages, 7 authors, 2008-02-22

Re: [PATCH RFC 4/7] [GPIO] Let drivers link if they support GPIO API as an addition

From: David Brownell <hidden>
Date: 2007-12-10 22:55:28

I'm interested in your opinion about that patch. You're also Cc'ed
to patch that using that feature.

I know, currently that patch will conflict with GPIOLIB patches in -mm,
so this is only RFC.
The point of CONFIG_GENERIC_GPIO is to be *the* conditional used to
tell whether that programming interface is available ... starting
from "#include <asm/gpio.h>", and including all gpio_*() calls.

So my first reaction is to not like this patch.  It changes semantics
in an incompatible way.  And AFAICT, needlessly so.

What other options did consider?  Like, why not #ifdef the GPIO parts
of that NAND driver, or have the whole driver depend on GENERIC_GPIO?

- Dave
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help