Re: [PATCH 1/3] ps3: vuart: fix error path locking

On Thu, 2007-12-20 at 12:06 -0800, Andrew Morton wrote:

On Thu, 20 Dec 2007 11:32:25 -0800 Daniel Walker [off-list ref] wrote:

quoted

On Tue, 2007-12-18 at 19:04 -0800, Geoff Levand wrote:

quoted

Unfortunately there wasn't enough context in the patch to see
that there is a down() earlier in the routine, and that the patch
does indeed remove an incorrectly placed down().  Here is the
entire routine, marked with what the patch removes.

Andrew have you had a chance to review this?

Confused.  I did review it: http://lkml.org/lkml/2007/12/18/384

Yeah, but Geoff countered http://lkml.org/lkml/2007/12/18/409

Do you still think the patch is wrong, given the whole function?

Daniel