Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality
From: Vitaly Bordug <hidden>
Date: 2007-12-01 22:23:18
Also in:
lkml, netdev
From: Vitaly Bordug <hidden>
Date: 2007-12-01 22:23:18
Also in:
lkml, netdev
On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov wrote:
quoted
If i understand your code correctly, you seem to rely on the fact that fixed_phy_add() is called before the fixed MDIO bus is scanned for devices.Yes, indeed. The other name of "fixed phys" are "platform phys" or "platform MDIO bus" on which virtual PHYs are placed. That is, these phys supposed to be created by the platform setup code (arch/). The rationale here is: we do hardware emulation, thus to make drivers actually see that "hardware", we have to create it early.
well that was the intention but... The point is - as device is emulated, (nearly) everything is doable, and the only tradeoff to consider, is how far will we go with that emulation. IOW, PHYlib could be tricked to "do the right thing", and I thought about adding module flexibility... But thinking more about it, it seems that BSP-code-phy-creation just sucks less and is clear enough yet flexible. -- Sincerely, Vitaly