Re: [PATCH v7 7/9] ipic: clean up unsupported ack operations

On Nov 30, 2007, at 4:03 AM, Li Yang wrote:

quoted

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, November 30, 2007 8:36 AM
To: Li Yang
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v7 7/9] ipic: clean up unsupported ack operations


On Oct 19, 2007, at 6:38 AM, Li Yang wrote:

quoted

IPIC controller doesn't support ack operations.  The

pending registers

quoted

are read-only.  The patch removes ack operations which are

not needed.

quoted

Signed-off-by: Li Yang <redacted>
---
arch/powerpc/sysdev/ipic.c |   40 +
+--------------------------------------
1 files changed, 2 insertions(+), 38 deletions(-)

applied.

Hi Kumar,

Please hold on this one.  Actually external interrupts in edge mode  
need
this ack operation.  But in most cases (level triggered) ack is not
needed.  I will provide an updated patch later on to take care both
trigger modes.  Thanks.

Ok, I'll drop this patch.

- k