RE: [PATCH v7 3/9] add Freescale SerDes PHY support
From: Liu Dave <hidden>
Date: 2007-11-21 03:49:37
On Oct 19, 2007, at 10:35 AM, Grant Likely wrote: =20quoted
On 10/19/07, Li Yang [off-list ref] wrote:quoted
The SerDes(serializer/deserializer) PHY block is a new SoC=20block usedquoted
quoted
in Freescale chips to support multiple serial interfaces,=20such as PCIquoted
quoted
Express, SGMII, SATA.This looks like board setup behaviour. Shouldn't setting this up be the responsibility firmware? And failing that, I think it should be done directly by the platform setup function (in other=20words; make itquoted
a helper function and call it at board setup time). =20Besides, you wantquoted
to provide guarantees that the board is setup correctly before the device driver that uses it gets probed. Cheers, g.=20 Upon further review of all this I don't think this belongs in the =20 kernel at all. This is one time setup and should be done in firmware.
The latest u-boot supports the serdes initialization for 837x. So, it can be dropped from kernel for now. Dave