Re: use of fsl, in lite5200b.dts in git current
From: Jon Smirl <hidden>
Date: 2007-11-08 20:40:55
No one has answered this yet. It makes no sense at all to mix use of the vendor prefix on some compatible entries and not on others. The syntax of compatible entries needs to be consistent. On 11/7/07, Jon Smirl [off-list ref] wrote:
On 11/7/07, Matt Sealey [off-list ref] wrote:quoted
Jon Smirl wrote:quoted
Sometimes the fsl prefix is being used and sometimes it isn't. Look at the two compatible strings. Which way is it going to be? Is fsl,has-wdt right?fsl,has-wdt is right, at least since someone changed it.What's the story with compatible? I would think the gdt entries are wrong. gpt@600 { // General Purpose Timer compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt"; code in drivers/watchdog/mpc5200_wdt.c would need to be changed to. drivers/watchdog/mpc5200_wdt.c: { .compatible = "fsl,mpc5200-gpt", }, -- Jon Smirl jonsmirl@gmail.com
-- Jon Smirl jonsmirl@gmail.com