Thread (7 messages) flat view 7 messages, 3 authors, 2007-10-19

Re: [PATCH v5 9/9] add MPC837x MDS board default device tree

From: David Gibson <hidden>
Date: 2007-10-19 00:56:13

On Thu, Oct 18, 2007 at 06:16:20PM +0800, Li Yang wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Li Yang <redacted>
---
diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts b/arch/powerpc/boot/dts/mpc8377_mds.dts
new file mode 100644
index 0000000..8530de6
--- /dev/null
+++ b/arch/powerpc/boot/dts/mpc8377_mds.dts
@@ -0,0 +1,282 @@
[snip]
+		crypto@30000 {
+			model = "SEC3";
+			compatible = "talitos";
That compatible doesn't look specific enough.  It should at least have
a vendor portion.  In general it's best to have all the information
you need to pick a driver and options in compatible, rather than
splitting that info into model.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help