RE: [PATCH v3 3/9] add Freescale SerDes PHY support

-----Original Message-----
From: linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org=20
[mailto:linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org]=20
On Behalf Of Arnd Bergmann
Sent: Friday, October 12, 2007 10:34 PM
To: linuxppc-dev@ozlabs.org
Cc: linuxppc-dev@ozlabs.org; paulus@samba.org
Subject: Re: [PATCH v3 3/9] add Freescale SerDes PHY support
=20
On Friday 12 October 2007, Li Yang wrote:

quoted

The SerDes(serializer/deserializer) PHY block is a new SoC=20

block used=20

quoted

in Freescale chips to support multiple serial interfaces,=20

such as PCI=20

quoted

Express, SGMII, SATA.

=20
Some of my comments here are similar to those for the ata=20
driver, so I won't be as verbose here
=20

quoted

+static int __init setup_serdes(struct device_node *np) {
+	void __iomem *regs;
+	const void *prot;
+	const unsigned int *freq;
+	struct resource res;
+	u32 rfcks;
+
+	of_address_to_resource(np, 0, &res);
+	regs =3D ioremap(res.start, res.end - res.start + 1);

=20
of_iomap?

I'd like to but of_iomap() couldn't provide the physical address of the
device used as identification.

- Leo