Re: [PATCH] PowerPC: add setup_cpu for 44x for processor-specific init
From: Valentine Barshak <hidden>
Date: 2007-09-20 18:16:55
From: Valentine Barshak <hidden>
Date: 2007-09-20 18:16:55
Josh Boyer wrote:
On Thu, 20 Sep 2007 21:55:58 +0400 Valentine Barshak [off-list ref] wrote:quoted
This adds cpu_setup functionality to PowerPC 44x platform. The cpu_setup callback is invoked by head_32 code and the identify_cpu() function at early init and is used to initialize FPU on 440EP(x) processors. The FPU initialization was previously done in head_44x.S. Also a workaround for the incorrect write to DDR SDRAM 440EPx/440GRx errata added. Data can be written to wrong address in SDRAM when write pipelining is enabled on plb0. The setup_cpu function for these processors disables write pipelining.Wow, you're fast ;) I'd like to see this split up a bit so there's not so much in one patch. Essentially, introduce cpu_setup_44x.S, move the FPU init to use it, and then add the PLB workaround.
OK
I still need to look at the code too :)
sure :)
josh
Thanks, Valentine.