Re: Sequoia kernel crash workaround.

On Wed, 19 Sep 2007 14:30:24 -0500
Olof Johansson [off-list ref] wrote:

On Wed, Sep 19, 2007 at 09:19:47PM +0200, Stefan Roese wrote:

quoted

Hi Valentine,

On Wednesday 19 September 2007, Valentine Barshak wrote:

quoted

Disabling write pipelining really helps.
Josh, David, what is the right place to put this workaround to?

Is it OK to do mtdcr(PLB4A0_ACR, mfdcr(PLB4A0_ACR) & ~PLB4_WRP); in
arch/powerpc/boot/cuboot-sequoia.c:sequoia_fixups()?
or
should this be done in
arch/powerpc/platforms/44x/sequoia.c:sequoia_setup_arch()
with dcr_map, dcr_read/write stuff?

I vote for putting it into sequoia.c, since it's very likely to happen that 
Sequoia will at one point be booted without the bootwrapper. Or perhaps it 
should go into some common code checking the PVR and disabling it when this 
440EPx/GRx is detected, since all those boards are affected.

This is what we have setup_cpu functions in the cpu table for. Please
put it there instead of in board code.

Yes, agreed.

josh