Re: [patch 1/4] cuimage for Bamboo board

On Sat, 2007-09-15 at 12:19 +1000, David Gibson wrote:

On Fri, Sep 14, 2007 at 01:54:11PM -0500, Josh Boyer wrote:

quoted

Add a cuboot wrapper for the Bamboo board.  This also removes some obsoleted
linker declarations that have been moved into ops.h

Signed-off-by: Josh Boyer <redacted>
Acked-by: David Gibson <redacted>

Heh, well, I know I acked this already, but...

:)

[snip]

quoted

--- /dev/null
+++ linux-2.6/arch/powerpc/boot/cuboot-bamboo.c

@@ -0,0 +1,30 @@
+/*
+ * Old U-boot compatibility for Ebony

Error in the comment here.

Fixed.

[snip]

quoted

--- linux-2.6.orig/arch/powerpc/boot/bamboo.c
+++ linux-2.6/arch/powerpc/boot/bamboo.c

@@ -24,8 +24,7 @@
 #include "4xx.h"
 #include "44x.h"
 
-extern char _dtb_start[];
-extern char _dtb_end[];
+static u8 *bamboo_mac0, *bamboo_mac1;

This additional handling of the MAC addresses should really also be
mentioned in the commit comment.

Quite right.  I'll revise the commit comment.

josh