RE: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.

Hi, Arnd,

I can change it as you metioned now.

Thanks!
-zw

-----Original Message-----
From: linux-kernel-owner@vger.kernel.org=20
[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Arnd Bergmann
Sent: Sunday, July 29, 2007 9:57 PM
To: linuxppc-dev@ozlabs.org
Cc: Zhang Wei-r63237; galak@kernel.crashing.org;=20
mporter@kernel.crashing.org; paulus@samba.org;=20
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5 v3] Add the platform device support=20
with RapidIO to MPC8641HPCN platform.
=20
On Thursday 26 July 2007, Zhang Wei wrote:

quoted

+
+static struct of_device_id mpc86xx_of_ids[] =3D {
+=A0=A0=A0=A0=A0=A0=A0{ .type =3D "soc", },
+=A0=A0=A0=A0=A0=A0=A0{ .compatible =3D "fsl,rapidio-delta", },
+=A0=A0=A0=A0=A0=A0=A0{},
+};

=20
With the device tree source you have posted in 2/5, the=20
rapidio node is
a child of the soc bus, and it doesn't have any children of its own.
Therefore it is completely equivalent to _only_ add the soc type
to mpc86xx_of_ids[], as in=20
=20
static struct of_device_id mpc86xx_of_ids[] =3D {
       { .type =3D "soc", },
       {},
};
=20
Even if you intend to add children to the rapidio node in the future,
I'd think it would be more appropriate to have those scanned by
the rapidio bus driver, not by of_platform.
=20
	Arnd <><
=20
-
To unsubscribe from this list: send the line "unsubscribe=20
linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
=20