Re: [patch] use __attribute__ in asm-powerpc

On Mon, 16 Jul 2007, Geert Uytterhoeven wrote:

On Sat, 14 Jul 2007, Mike Frysinger wrote:

quoted

Pretty much everyone uses "__attribute__" or "attribute", no one
uses "__attribute".  This patch tweaks the three places in asm-powerpc where
this comes up.  While only asm-powerpc/types.h is interesting (for userspace),
I did asm-powerpc/processor.h as well for consistency.

Signed-off-by: Mike Frysinger <redacted>
---

diff --git a/include/asm-powerpc/processor.h b/include/asm-powerpc/processor.h
index d947b16..2ce6ea6 100644
--- a/include/asm-powerpc/processor.h
+++ b/include/asm-powerpc/processor.h

@@ -153,9 +153,9 @@ struct thread_struct {
 	unsigned long	dabr;		/* Data address breakpoint register */
 #ifdef CONFIG_ALTIVEC
 	/* Complete AltiVec register set */
-	vector128	vr[32] __attribute((aligned(16)));
+	vector128	vr[32] __attribute__((aligned(16)));

If the code is not exported to userspace (and thus not subject to
different compilers), I think the preferred form is plain
`attribute'.

compiler-gcc.h also defines the common form of the shortcut:

#define __aligned(x)                    __attribute__((aligned(x)))

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================