Re: [patch] use __attribute__ in asm-powerpc
From: Geert Uytterhoeven <hidden>
Date: 2007-07-16 09:18:52
Also in:
lkml
On Sat, 14 Jul 2007, Mike Frysinger wrote:
quoted hunk ↗ jump to hunk
Pretty much everyone uses "__attribute__" or "attribute", no one uses "__attribute". This patch tweaks the three places in asm-powerpc where this comes up. While only asm-powerpc/types.h is interesting (for userspace), I did asm-powerpc/processor.h as well for consistency. Signed-off-by: Mike Frysinger <redacted> ---diff --git a/include/asm-powerpc/processor.h b/include/asm-powerpc/processor.h index d947b16..2ce6ea6 100644 --- a/include/asm-powerpc/processor.h +++ b/include/asm-powerpc/processor.h@@ -153,9 +153,9 @@ struct thread_struct { unsigned long dabr; /* Data address breakpoint register */ #ifdef CONFIG_ALTIVEC /* Complete AltiVec register set */ - vector128 vr[32] __attribute((aligned(16))); + vector128 vr[32] __attribute__((aligned(16)));
If the code is not exported to userspace (and thus not subject to different compilers), I think the preferred form is plain `attribute'. With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619