Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

On 7/19/07, Kim Phillips [off-list ref] wrote:

On Thu, 19 Jul 2007 13:43:17 -0600
"Grant Likely" [off-list ref] wrote:

quoted

On 7/19/07, Scott Wood [off-list ref] wrote:

quoted

Grant Likely wrote:

quoted

From: Grant Likely <redacted>

To boot from a cuImage requires the device tree to have a
linux,stdout-path property in the chosen node.  This patch adds it
to the .dts files.

This will break many current u-boots, as they blindly add a /chosen node
regardless of whether one already exists.

That really should be fixed then.  In the meantime; I'll resubmit the
patch to add the chosen node; but with it commented out.

the old FLAT_TREE u-boot fdt fixup code renames any existing chosen
node out of the way, and adds its fixed up version as /chosen.

The LIBFDT implementation replaces any existing /chosen with its fixed
up version.

So it all works out.  Adding chosen/linux,stdout-path properties to the
kernel dtses is fine.

btw, why are these changes being limited to the ITX and GP?

Simply because I'm working on an itx-gp board.  If this is deemed to
be a good change, I can whip up a patch to fix all boards with my
'best guess' as to what stdout should be.

Cheers,
g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195