Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

Grant Likely wrote:

On 7/19/07, Scott Wood [off-list ref] wrote:

quoted

Grant Likely wrote:

quoted

From: Grant Likely <redacted>

To boot from a cuImage requires the device tree to have a
linux,stdout-path property in the chosen node.  This patch adds it
to the .dts files.

This will break many current u-boots, as they blindly add a /chosen node
regardless of whether one already exists.

That really should be fixed then.  In the meantime; I'll resubmit the
patch to add the chosen node; but with it commented out.

g.

We are working on fixing that with the "u-boot-fdt" subtree, but it is 
slow going and it will not magically fix already fielded boards. 
(Forget that Harry Potter crap magic, _that_ would be some useful magic!)

I think the "proper" solution is not to add the /chosen node in the dts 
but rather to generate a _correct_ one in u-boot.  Note that 
linux,stdout-path is something that _should_ be generated based on the 
u-boot configuration (currently it is hard #defined, IMHO it should be 
part of the u-boot environment).

Looks like it is at fdt_support.c line 152:
<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=blob;f=common/fdt_support.c;h=259bd42cc62c55d11370579a7af0d6519fc34c8d;hb=fdt#l152>

Best regards,
gvb