Re: [PATCH] Add StorCenter DTS first draft.

So, like, the other day Segher Boessenkool mumbled:

quoted

+/ {
+	model = "StorCenter";

If you can find a real model number, put it in here, instead.

Yep, "StorCenter" is it.  No model numer/name beyond that.

quoted

+	compatible = "storcenter";

Needs a manufacturer name in there.

Right.  Will use:
	compatible = "iomega,storcenter"

quoted

+		PowerPC,603e {			/* Really 8241 */

So say "PowerPC,8241@0", or "PowerPC,e300@0" (or whatever
the CPU core in there is), or simply "cpu@0", following
the generic naming recommended practice.

Well, its the 8241 SoC with a 603e core...  (This is
the same phrase currently being used on the Kurobox.)
I'll use:

	PowerPC,8241@0 }

quoted

+			bus-frequency = <0>;

Is this filled in anywhere?  Please document that, if so.

Right.  boot{loader,wrapper}

quoted

+	soc10x {

Bad name.  Where is the binding for this?  I don't think
I saw it before.

It's what is being used, again, by the Kurobox.  I understand
that doesn't make it "right", just precedented by now.

How about "soc8241@80000000" instead?

That would be similar to:
        soc8641@f8000000 {
and
       soc8272@f0000000 {

quoted

+		store-gathering = <0>; /* 0 == off, !0 == on */

Don't define this as "!0", but as "1".

OK.

quoted

+		i2c@fdf03000 {
+			device_type = "i2c";

No device_type, there is no I2C binding.

Right.

quoted

+			compatible = "fsl-i2c";

Needs to be more specific.

Hmmm...  Not sure what to use here then.  There are many
existing examples using "fsl-i2c" already.  Granted, we've
established that they could be wrong...  Should this be
more like this?:

    compatible = "fsl,mpc8241-i2c", "fsl-i2c";

quoted

+		mpic: pic@fdf40000 {

interrupt-controller@fdf40000

OK.

quoted

+		pci@fe800000 {
+			clock-frequency = <d# 100000000>; /* Hz */

100MHz PCI?  Interesting.

Good point. 66666666 seems more likely...


Thanks for the review and help here!

jdl