Re: [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN

On Thu, 2007-06-07 at 00:39 +0200, Arnd Bergmann wrote:

On Wednesday 06 June 2007, Wade Farnsworth wrote:

quoted

+       /* LPC47M192 Super I/O configuration */
+       outb(0x55, 0x4e);       /* enter superio config mode */
+
+       /* Enable keyboard and mouse */
+       outb(0x07, 0x4e);       /* device selector register */
+       outb(0x07, 0x4f);       /* select keyboard registers (device 7) */
+       outb(0x30, 0x4e);       /* keyboard activation register */
+       outb(0x01, 0x4f);       /* activate keyboard */

Hardcoded I/O port numbers always worry me a little. I know that this is
supposed to work in general, but can't you read the I/O port range from
a device tree property?

I suppose I could create a device node for the Super I/O config
registers and use those instead of hardcoding it here.

Something to the effect of:

superio_cfg@4e {
	reg = <1 4e 2>;
	compatible = "smsc-lpc47m192-cfg";
};

I'm not sure if the name and compatible properties are appropriate
though.  Any recommendations?

--Wade