Re: [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN

On Wednesday 06 June 2007, Wade Farnsworth wrote:

+=A0=A0=A0=A0=A0=A0=A0/* LPC47M192 Super I/O configuration */
+=A0=A0=A0=A0=A0=A0=A0outb(0x55, 0x4e);=A0=A0=A0=A0=A0=A0=A0/* enter supe=

rio config mode */

+
+=A0=A0=A0=A0=A0=A0=A0/* Enable keyboard and mouse */
+=A0=A0=A0=A0=A0=A0=A0outb(0x07, 0x4e);=A0=A0=A0=A0=A0=A0=A0/* device sel=

ector register */

+=A0=A0=A0=A0=A0=A0=A0outb(0x07, 0x4f);=A0=A0=A0=A0=A0=A0=A0/* select key=

board registers (device 7) */

+=A0=A0=A0=A0=A0=A0=A0outb(0x30, 0x4e);=A0=A0=A0=A0=A0=A0=A0/* keyboard a=

ctivation register */

+=A0=A0=A0=A0=A0=A0=A0outb(0x01, 0x4f);=A0=A0=A0=A0=A0=A0=A0/* activate k=

eyboard */

Hardcoded I/O port numbers always worry me a little. I know that this is
supposed to work in general, but can't you read the I/O port range from
a device tree property?

	Arnd <><