On May 29, 2007, at 6:41 AM, Benjamin Herrenschmidt wrote:

On Tue, 2007-05-29 at 13:32 +0200, Christoph Hellwig wrote:

quoted

On Tue, May 29, 2007 at 04:45:23PM +1000, Benjamin Herrenschmidt
wrote:

quoted

+static inline void check_syscall_restart(struct pt_regs *regs,
+                                      struct k_sigaction *ka,
+                                      int has_handler)
+{

I don't think this should be inlined.  Just create a new signal.c
file,
which can grow a lot more common signal code later on aswell.

I've been thinking about doing that too. In fact, some of the
ptrace-common.h stuff should probably be turned back into ptrace.c too
for the same reason. I'm still toying with that part of the designm  
but
yeah, I think that's something to do.

I think this makes sense for the ptrace code as well.  Eventually  
we'll end up moving or supporting some of the 'features' that only  
exist on one platform or the other in both.  I can see us supporting  
PTRACE_{GET,SET}_DEBUGREG on ppc32 and we'll need to support the  
BOOKE stuff on ppc64.

- k