Re: Fix problems with Holly's DT representation of ethernet PHYs
From: David Gibson <hidden>
Date: 2007-05-24 05:59:09
On Wed, May 23, 2007 at 11:22:34PM -0500, Kumar Gala wrote:
On May 23, 2007, at 11:16 PM, David Gibson wrote:quoted
This patch fixes some problems with the way the Ethernet PHYs are represented in the device tree for the Holly board. This means changes to the dts itself, and to the code with instantiates the tsi108 ethernet platform devices based on the device tree. - First, and most importantly, the PHYs are given with an identical 'reg' property. This reg currently encodes the accessible register used to initiate mdio interaction with the PHYs, rather than a meaningful address on the parent bus (mdio in this case), which is incorrect. Instead we give the address of these registers as 'reg' in the mdio node itself, and encode the ID of each phy in their 'reg' propertys. The PHY's unit name addresses are updated to match. - Second, the PHYs give only "bcm54xx" as a compatible property. This is unfortunate, because there are many bcm54xx PHY models, and they have differences which can matter. We add a more precise compatible string, giving the precise PHY model (bcm5461A in this case).Is the compatible really need here? We are able to provide and bind drivers based on MII_PHYSID1/2. I don't see what putting the compatible proper gets us.
That's a good point (except that having a node without compatible is kind of odd). At the moment the code which instantiates the platform device looks at compatible to enable a workaround. But actually that workaround is holly specific, rather than related to the PHY model, and so should be encoded differently. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson