Re: Small fixes for the Ebony device tree
From: Segher Boessenkool <hidden>
Date: 2007-05-14 15:03:52
- i-cache-size = <0>; - d-cache-size = <0>; + i-cache-size = <2000000>; /* 32 kB */ + d-cache-size = <2000000>; /* 32 kB */
That's 32MB, not 32kB. Better fix this :-)
UIC0: interrupt-controller0 { UIC1: interrupt-controller1 {It's a shame you can't use unit addresses for these since you use "dcr-reg" instead of "reg". Oh well.
SDRAM0: sdram {
- device_type = "memory-controller";
compatible = "ibm,sdram-440gp", "ibm,sdram";Maybe rename the node to "memory-controller"?
+ SRAM0: sram {
+ compatible = "ibm,sram440gp";
+ dcr-reg = <020 8 00a 1>;
+ };Is this thing _only_ addressable over DCRs? Weird.
MAL0: mcmal {
- device_type = "mcmal-dma";
+ device_type = "dma-controller";
compatible = "ibm,mcmal-440gp", "ibm,mcmal";Remove "device_type", change name to "dma-controller"?
EBC0: ebc {
- device_type = "ibm,ebc";
compatible = "ibm,ebc-440gp";You forgot "ibm,ebc" here. Segher