Thread (12 messages) flat view 12 messages, 3 authors, 2007-05-12

Re: [PATCH 7/7] MPIC U3/U4 MSI backend

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-05-12 09:06:47

On Sat, 2007-05-12 at 10:28 +0200, Johannes Berg wrote:
quoted
+	pr_debug("u3msi: allocated virq 0x%x (hw 0x%lx) at address 0x%lx\n",
+		 virq, virq_to_hw(virq), addr);
I get
arch/powerpc/sysdev/mpic_u3msi.c: In function ‘u3msi_compose_msi_msg’:
arch/powerpc/sysdev/mpic_u3msi.c:121: warning: format ‘%lx’ expects type
‘long unsigned int’, but argument 4 has type ‘u64’

when building this on ppc32 (I wonder if that even makes sense anyway
but Kconfig allowed me to select MSI)
Hrm... we should definitely make the U3 MSI bits 64 bits only for now at
least.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help