Re: [PATCH 7/7] MPIC U3/U4 MSI backend

On Tue, 2007-05-08 at 10:55 +0200, Johannes Berg wrote:

On Tue, 2007-05-08 at 12:58 +1000, Michael Ellerman wrote:

quoted

MPIC U3/U4 MSI backend. Based on code from Segher, heavily hacked by me.
This only deals with MSI on U3/U4 MPICs, aka. CPC 9x5.

If we find a U3/U4 then we enable this backend, ie. take over the ppc_md
MSI hooks. We might need more elaborate logic in future to decide which
backend is enabled.

We need our own irq_chip so that we can do MSI masking/unmasking on
the device itself. We also need to mask explicitly on shutdown to make
sure we don't get bitten by lazy-disable semantics.

How badly will this clash with my patch that implements suspend/resume
for mpic, and will I need to do more suspend/resume for this?

Maybe... for now, don't bother, we'll do fixups later on. I think your
patch can be done differently and more simply. I don't think we need to
save/restore all this state, we can proably reconfigure everything with
what we have.

Ben.