Re: [PATCH 12/14] Add device tree for Ebony
From: David Gibson <hidden>
Date: 2007-02-21 00:32:43
On Tue, Feb 20, 2007 at 09:09:51AM -0600, Josh Boyer wrote:
On Tue, 2007-02-20 at 13:12 +1100, David Gibson wrote:quoted
Add a device tree for the Ebony evaluation board (440GP based). This tree is not complete or finalized. This tree needs a very recent version of dtc to process. Signed-off-by: David Gibson <redacted> --- arch/powerpc/boot/dts/ebony.dts | 225 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 225 insertions(+) Index: working-2.6/arch/powerpc/boot/dts/ebony.dts ===================================================================--- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ working-2.6/arch/powerpc/boot/dts/ebony.dts 2007-02-19 15:31:36.000000000 +1100@@ -0,0 +1,225 @@ +/* + * Device Tree Source for IBM Ebony + * + * Copyright (c) 2006, 2007 IBM Corp. + * Josh Boyer <jdub@us.ibm.com>, David Gibson <dwg@au1.ibm.com>That email address died about 2 weeks ago. Feel free to change it to this one: jwboyer@linux.vnet.ibm.com
Done [snip]
quoted
+ plb { + device_type = "ibm,plb"; + compatible = "ibm,plb-440gp", "ibm,plb4"; + #address-cells = <2>; + #size-cells = <1>; + ranges; + + POB0: opb@0 {I think you meant "OPB0:" for the label.
Not really. The 440GP user manual refers to the bridge (as opposed to the bus) as POB0. The label is meant to reflect that.
quoted
+ device_type = "ibm,opb"; + compatible = "ibm,opb-440gp", "ibm,opb";As I pointed out in an earlier email, this breaks working with the current legacy_serial driver. It's looking for a device_type of "opb". I'm not sure if we should fix the driver or fix this and the ebony_of_bus types in arch/powerpc/platforms/4xx/ebony.c
That's kind of deliberate. The idea is to use the of_serial stuff instead of legacy_serial. legacy_serial was really meant for *legacy* (i.e. ISA) serial ports, not these on chip things. The revised version of ebony.c already scans ibm,plb and ibm,opb busses for OF devices. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson