Re: [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot)
From: David Gibson <hidden>
Date: 2007-02-18 00:22:20
On Tue, Feb 13, 2007 at 09:32:11AM -0800, Geoff Levand wrote:
Scott Wood wrote:quoted
quoted
It may be better to do it like this, as there will be more platforms that need to hook in specific files. src-plat-$(CONFIG_COMPAT_UIMAGE) += $(cuboot-plats:%=cuboot-%.c) src-plat-$(CONFIG_XXX) += ... src-plat-$(CONFIG_YYY) += ... ... src-plat := of.c $(src-plat-y)Take it up with Paul. He said that all platform files shall always be built, and that the wrapper script picks which ones to link.That is what this sets up, for all platforms the kernel is built to support, all the corresponding wrapperbits are built. The problem I see with what you have done is that if there is a single bug in the wrapperbits for any platform, all zImage builds for ANY platform will fail, even platforms the kernel is not configured to support. I think most people only build for a few platforms and would not want to be inconvenienced buy a bug in a platform they have no interest in, and in general, I don't think platform maintainers want to inconvenience people with platform specific bugs when they are not building for that platform.
On the other hand, this property means it's far less likely that people will break platforms they're not actively working on at the time. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson