Re: [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot)

On Mon, Feb 12, 2007 at 01:38:52PM -0800, Geoff Levand wrote:

Scott Wood wrote:

quoted

+config CUIMAGE_DTS

There is nothing CUIMAGE specific with this, so why make it so?  Other
platforms may like to use it.

Fine, I'll make it BUILTIN_DTS or something.

It may be better to do it like this, as there will be more platforms that
need to hook in specific files.

src-plat-$(CONFIG_COMPAT_UIMAGE) += $(cuboot-plats:%=cuboot-%.c)
src-plat-$(CONFIG_XXX) += ...
src-plat-$(CONFIG_YYY) += ...
...
src-plat := of.c $(src-plat-y)

Take it up with Paul.  He said that all platform files shall always be
built, and that the wrapper script picks which ones to link.

quoted

+ifeq ($(CONFIG_COMPAT_UIMAGE),y)
+cuboot-plat-$(CONFIG_83xx) += 83xx
+cuboot-plat-$(CONFIG_85xx) += 85xx
+cuboot-plat-$(CONFIG_86xx) += 86xx
+cuboot-plat-y += unknown-platform
+
+$(obj)/uImage: vmlinux $(wrapperbits)
+	$(call cmd,wrap_dt,cuboot-$(word 1,$(cuboot-plat-y)))
+else
 $(obj)/uImage: vmlinux $(wrapperbits)
 	$(call cmd,wrap,uboot)
+endif

It would be nice if you could make the logic such that you don't need this ifeq.

Do you mean naming the target something other than uImage?

-Scott